fix: オンゲキNET反映前曲をプレイした場合に全曲取得/履歴取得の切り替えが上手く働かない問題を修正#947
Merged
slime-hatena merged 3 commits intoproject-primera:developfrom Nov 2, 2025
Merged
Conversation
Member
これは許容で良さそうです(スコアツールを使う人はモチベが高いので結構やってるがち) |
Contributor
Author
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the logic for handling play history when checking for new scores. The change addresses edge cases where the number of history items may not be exactly 50, and handles the scenario where no history is available.
Key changes:
- Modified the condition to check if any play history exists (length > 0) instead of checking for exactly 50 items
- Added logic to handle the case where no play history exists (length = 0), which triggers a full song retrieval
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
遅くなってすみません... ちょっとローカルでQAできていないのですが大丈夫そうなのでマージします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
オンゲキNETにまだ反映されていない曲をプレイした場合その分の履歴が記録されず、結果として履歴件数が50件を下回り、オンゲキの新規ユーザー向けに設定していた履歴件数=50の条件を突破できなかったことで50曲以上プレイしているのにもかかわらず全曲取得が行われない現象を修正。
実装概要
履歴件数=50の条件を削除
結果
上記不具合の修正
これによって起こる可能性のある現象
初めてスコアログにスコアを登録する履歴件数50曲未満のユーザーが登録を行う場合、履歴取得ではなく全件取得が実行される。