Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: オンゲキNET反映前曲をプレイした場合に全曲取得/履歴取得の切り替えが上手く働かない問題を修正
Missing space after comma in sprintf function call. For consistency with line 332 which has sprintf(\"%.3f\",($newNormalRating - $oldNormalRating)), consider adding a space after the comma: sprintf(\"%.3f\", $newNormalRating). Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat: 更新差分へのレート差分表示
「現在の状態:」を向こうで出さないのは画面の変化をつけてステートをわかりやすくする意図
なんか治るからこれで行きます。 多分object担っちゃうんだと思うけど、クエリ的にも軽いはずなのでこっちに
未だに問い合わせが来るので終わったんだよということを強調
ありえないと思うけどな～～～ Potential undefined array key error if 'private' is not present in the $data array. When the checkbox is unchecked, it may not be included in the request data. Use isset($data['private']) && $data['private'] ? 1 : 0 or add a default value of 0. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
プライベートモードの実装
|
Merging this request will create release: Don't edit the merge commit message. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a private mode feature for user profiles and deprecates Twitter integration. Users can now hide their profile from other users while still being included in statistics. The PR also adds single rating display in the progress view and fixes a bug in the score retrieval bookmarklet.
Key changes:
- Added private mode toggle functionality allowing users to hide their profiles from non-admin users
- Deprecated Twitter authentication feature
- Enhanced progress view to display single rating values for score updates
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| routes/web.php | Added routes for private/public mode settings; commented out Twitter auth route |
| resources/views/setting.blade.php | Replaced Twitter integration UI with private mode controls |
| resources/views/auth/register.blade.php | Added private mode checkbox to registration form |
| resources/views/user_progress.blade.php | Added single rating display to score difference view |
| resources/assets/js/bookmarklets/getScore.ts | Fixed logic to handle empty play history (50 consecutive unregistered songs) |
| database/migrations/2025_08_13_115922_create_private_mode_flag.php | Added private column to users table |
| app/User.php | Added private to fillable attributes |
| app/UserStatus.php | Added private user filtering logic to data retrieval methods |
| app/Http/Controllers/SettingController.php | Implemented private/public mode toggle endpoints |
| app/Http/Controllers/Auth/RegisterController.php | Added private field handling during registration |
| app/Http/Controllers/ViewUserRatingController.php | Added warning comment about duplicated lamp calculation logic |
| app/Http/Controllers/ViewUserProgressController.php | Added single rating calculation to progress display |
| app/Http/Controllers/ViewMusicStatisticsController.php | Modified to include private users in music statistics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ありがたいことにユーザーが増えて重すぎぃです
ユーザー一覧をプレソートするように
|
Merging this request will create release: Don't edit the merge commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.