Attachment upload with file dialog by alanpoon · Pull Request #674 · project-robius/robrix

alanpoon · 2026-01-26T13:38:42Z

Screen.Recording.2026-01-26.at.4.09.11.PM.mov

macOS
Android
Linux
Windows

kevinaboos · 2026-01-27T08:01:22Z

awesome!

I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.

Plus, with rfd you'd get immediate support for all 3 desktop platforms.

alanpoon · 2026-01-28T13:10:50Z

awesome!

I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.

Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

kevinaboos · 2026-01-28T17:48:50Z

awesome!
I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.
Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

Ok, what's the issue with that? Is that problematic? Apologies, but I'm not quite sure what point you're trying to make.

Moly has used rfd in their app, works fine AFAIK.

alanpoon · 2026-01-30T16:19:32Z

awesome!
I know this isn't yet complete, but I wanted to quickly drop in and suggest using rfd instead of makepad's internal file API. rfd is the de facto crate for this kind of thing, and I plan to shortly create a robius crate that wraps rfd, so we'll end up with a similar API.
Plus, with rfd you'd get immediate support for all 3 desktop platforms.

Kindly refer to this implementation of the rfd. https://github.com/Vjze/YY_DPS/blob/edb15ffc85b646c27547081b30a0e6f0d8ba688b/src/export/export_view.rs#L158 This requires the tokio runtime in a field in export screen

Ok, what's the issue with that? Is that problematic? Apologies, but I'm not quite sure what point you're trying to make.

Moly has used rfd in their app, works fine AFAIK.

Thanks for referring me to Moly. File Dialog does not work well in asynchronously in macOS as file dialog is only allowing in main thread.

src/sliding_sync.rs

src/shared/progress_bar.rs

src/sliding_sync.rs

src/shared/file_previewer.rs

src/app.rs

kevinaboos

Thanks Alan, looks very good — impressive work here!

I left comments about a few major structural decisions, but it's mostly just about refactoring things into more modular widgets. I also left some questions about using higher-level Timeline APIs vs Room APIs for sending attachments.

src/room/room_input_bar.rs

kevinaboos · 2026-02-05T03:10:40Z

macOS

Android

Linux

Windows

Also, now that you're using rfd, can you confirm whether this also works for Linux and Windows? Theoretically they are also included as supported platforms in rfd.

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

…o image_upload

kevinaboos

Looks pretty good, just a few minor comments.

src/home/upload_progress.rs

kevinaboos · 2026-02-25T18:01:10Z

src/room/room_input_bar.rs

+    /// Counter for generating unique IDs for file load tasks.
+    #[rust] file_load_task_id_counter: u32,
+    /// The pending file load operation, if any. Contains the task ID and receiver
+    /// channel for receiving the loaded file data from a background thread.
+    #[rust] pending_file_load: Option<(u32, FileLoadReceiver)>,


it looks like neither of these u32 values are used any more, correct? If so, please remove them.

Seems like they wouldn't be needed anyway now that you're using proper TimelineUpdate channels for this stuff.

Remove file_load_task_id_counter

kevinaboos · 2026-02-25T18:06:30Z

src/room/room_input_bar.rs

+                    draw_icon: {
+                        svg_file: (ICON_ADD_ATTACHMENT)
+                        color: (COLOR_ACTIVE_PRIMARY_DARKER)
+                    },
+                    draw_bg: {
+                        color: (COLOR_PRIMARY),
+                    }


I think you've flipped these. The background color should be COLOR_ACTIVE_PRIMARY (blue), and the foreground color (both text and icon) should be COLOR_PRIMARY (white)

Change to follow "location_button"

kevinaboos · 2026-02-25T18:11:45Z

src/room/room_input_bar.rs

+            }
+            if remove_receiver {
+                self.pending_file_load = None;
+                cx.set_cursor(MouseCursor::Default);


nit: why is this needed? I suppose it doesn't hurt, but I don't see how it's beneficial. The cursor should be based on what the mouse is hovering over, right?

Remove "cx.set_cursor(MouseCursor::Default);"

kevinaboos · 2026-02-25T18:40:12Z

src/shared/file_upload_modal.rs

+    }
+}
+
+/// Actions emitted by the `FileUploadModal` widget.


nit: are these actions actually emitted by the FileUploadModal widget? seems like they aren't necessarily; please update the doc comments to be clear for each variant.

Updated the doc comments.

src/room/room_input_bar.rs

kevinaboos · 2026-02-25T19:21:28Z

src/sliding_sync.rs

+                    let mime_type  = file_meta.mime.clone();
+                    let attachment_config = matrix_sdk_ui::timeline::AttachmentConfig {
+                        txn_id: None,
+                        info: None,


shouldn't you fill in this info here, especially since most of it is already available as part of the file_data?

note that we do rely on this basic image info when showing images in the RoomScreen timeline, so it's only fair to expect that we should provide it to Robrix and other clients as well when uploading an image/file.

kevinaboos · 2026-02-25T19:23:47Z

src/sliding_sync.rs

+                    let mut subscriber = send_attachment.subscribe_to_send_progress();
+                    let timeline_update_sender = sender.clone();
+                    Handle::current().spawn(async move {
+                        while let Some(progress) = subscriber.next().await {
+                            sender.send(TimelineUpdate::FileUploadUpdate { current: progress.current as u64, total: file_meta.file_size }).unwrap_or_else(|e| {
+                                error!("Failed to send progress update to UI: {e:?}");
+                            });
+                            SignalToUI::set_ui_signal();
+                        }
+                    });
+                    timeline_update_sender.send(TimelineUpdate::FileUploadUpdate { current: 0, total: file_meta.file_size }).unwrap_or_else(|e| {
+                        error!("Failed to send initial progress update to UI: {e:?}");
+                    });
+                    match send_attachment.await {
+                        Ok(_) => {
+                            log!("Successfully uploaded and sent file to {timeline_kind}");
+                            timeline_update_sender.send(TimelineUpdate::FileUploadUpdate { current: file_meta.file_size, total: file_meta.file_size }).unwrap_or_else(|e| {
+                                error!("Failed to send progress update to UI: {e:?}");
+                            });
+                            SignalToUI::set_ui_signal();
+                        }
+                        Err(e) => {
+                            error!("Failed to upload file to {timeline_kind}: {e:?}");
+                            // Set progress to completion state (0/0) to hide the progress bar
+                            timeline_update_sender.send(TimelineUpdate::FileUploadUpdate { current: 0, total: 0 }).unwrap_or_else(|e| {
+                                error!("Failed to send progress update to UI: {e:?}");
+                            });
+                            SignalToUI::set_ui_signal();
+                            enqueue_popup_notification(format!("Failed to upload file: {e}"), PopupKind::Error, None);
+                        }
+                    }
+                });


can you improve the formatting of this? it's hard to read. Needs more whitespace newlines for separation, and better wrapping to avoid very long lines (ideally not much longer than 100 chars)

Fix formatting.

kevinaboos · 2026-02-25T19:27:24Z

src/sliding_sync.rs

+                            timeline_update_sender.send(TimelineUpdate::FileUploadUpdate { current: 0, total: 0 }).unwrap_or_else(|e| {
+                                error!("Failed to send progress update to UI: {e:?}");
+                            });
+                            SignalToUI::set_ui_signal();
+                            enqueue_popup_notification(format!("Failed to upload file: {e}"), PopupKind::Error, None);


While this technically works, it's not a great user experience.

Don't just hide the progress bar and show a popup notification error from the background task here. That doesn't allow the user to retry if anything went wrong (e.g., a temporary network disconnection).

Instead, send a variant of the FileUploadUpdate action with the explicit error to the UI, such that we can then show a retry button in the UI to allow the user to (1) see the error, and (2) attempt to re-send it.

Added Retry button.

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

alanpoon added 7 commits January 23, 2026 21:46

add image upload

72020cb

added progress bar widget

824b6cf

file upload modal

ba038cc

added file_previewer

51e388c

code improvement

172462b

fix clippy

13109ff

add FilePreviewer in App

bdb0b34

alanpoon self-assigned this Jan 26, 2026

alanpoon added 2 commits January 30, 2026 15:54

image upload improvement

0ca00fb

Merge branch 'main' into image_upload

2afea24

alanpoon added the waiting-on-review This issue is waiting to be reviewed label Jan 30, 2026

alanpoon marked this pull request as ready for review January 30, 2026 16:18

image_upload improvement

f922cf2

alanpoon force-pushed the image_upload branch from eae0bfa to f922cf2 Compare January 31, 2026 01:38

fix clippy

59860ab

kevinaboos reviewed Feb 5, 2026

View reviewed changes

kevinaboos requested changes Feb 5, 2026

View reviewed changes

kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Feb 5, 2026

kevinaboos assigned kevinaboos and alanpoon and unassigned alanpoon Feb 5, 2026

kevinaboos added the waiting-on-author This issue is waiting on the original author for a response label Feb 5, 2026

alanpoon added 3 commits February 5, 2026 11:55

Merge branch 'main' into image_upload

cc335f7

send attachment improvement

36b2432

fix file upload modal white space issue

e41250c

kevinaboos added the waiting-on-author This issue is waiting on the original author for a response label Feb 19, 2026

alanpoon added 2 commits February 23, 2026 09:15

Merge branch 'main' into image_upload

6f198d0

image_upload fix after review

81f4718

alanpoon force-pushed the image_upload branch from e78c41b to 81f4718 Compare February 24, 2026 08:25

alanpoon and others added 4 commits February 24, 2026 16:35

fix hiding issue in UploadProgressView

916353c

cleanup extra line

99b2df5

max width fix

b4fb87b

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

format fix

19630ea

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

alanpoon added 2 commits February 25, 2026 09:25

code improvement

e9ca7ee

Merge branch 'image_upload' of https://github.com/alanpoon/robrix int…

65acc69

…o image_upload

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Feb 25, 2026

kevinaboos requested changes Feb 25, 2026

View reviewed changes

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Feb 25, 2026

alanpoon and others added 8 commits February 26, 2026 08:25

Avoid string allocations

3338a8b

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

remove string allocation

98d230e

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

PopupItem Fix

295ea3d

Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com>

fix format

e1007c6

Add retry button

c85e246

Merge branch 'main' into image_upload

b702d7e

fix clippy

b3bc48f

fix formatting

c874b5a

alanpoon added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Feb 26, 2026

Fix clippy

7f7f08b

Conversation

alanpoon commented Jan 26, 2026

Uh oh!

kevinaboos commented Jan 27, 2026

Uh oh!

alanpoon commented Jan 28, 2026

Uh oh!

kevinaboos commented Jan 28, 2026

Uh oh!

alanpoon commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinaboos commented Feb 5, 2026

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants