⚡ Bolt: Avoid redundant clone in media cache insert#764
⚡ Bolt: Avoid redundant clone in media cache insert#764kevinaboos wants to merge 1 commit intomainfrom
Conversation
…ters Removes a redundant `clone()` of `MediaRequestParameters` in `insert_into_cache`. The `request` variable is owned by the function and not used after the point where it was cloned, so it can be moved instead. This avoids potentially expensive string allocations (e.g. for the MXC URI) on every media fetch. Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Removed an unnecessary
.clone()call onMediaRequestParametersinsrc/media_cache.rs.🎯 Why:
MediaRequestParameterscontainsOwnedMxcUri(a string wrapper) and other data. Cloning it is an unnecessary allocation because the original variablerequestis not used afterwards in theinsert_into_cachefunction.📊 Impact: Reduces memory allocations and CPU cycles for every media fetch operation (images, avatars, etc.). While micro-optimization, it affects a frequent path in media-heavy rooms.
🔬 Measurement: Verified via
cargo checkthat ownership rules are satisfied. No regression in logic asrequestwas implicitly dropped immediately after the clone previously.PR created automatically by Jules for task 12072460591131631633 started by @kevinaboos