Open
Conversation
Contributor
|
I've seen it as well, would be great to have it fixed in the lib directly, could be someone setting orders with very large prices that causes that? not sure. |
Author
|
@armaniferrante, can help take a look with this? Some serum orderbook break when fetching l2 because of large number, this would mitigate it |
Contributor
|
@ZhengYuTay I think this fix is incorrect in away not preserving decimal places, I think https://github.com/MikeMcl/big.js/ should be used instead for making division? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the time calling
toNumber()would result inNumber can only safely store up to 53 bits, workaround is to just calltoString()intoNumber()