Don't create open orders account if it already exists.#237
Open
partiallysorted wants to merge 1 commit intoproject-serum:masterfrom
Open
Don't create open orders account if it already exists.#237partiallysorted wants to merge 1 commit intoproject-serum:masterfrom
partiallysorted wants to merge 1 commit intoproject-serum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing with the serum-ts library I noticed that if I had already created the open orders account, but not yet placed and order, the library would attempt to create a new account. I believe that the library should use the supplied open orders account if it exists instead of creating a new account.