feat: Find price impact of swap#90
Open
secretshardul wants to merge 1 commit intoproject-serum:masterfrom
Open
feat: Find price impact of swap#90secretshardul wants to merge 1 commit intoproject-serum:masterfrom
secretshardul wants to merge 1 commit intoproject-serum:masterfrom
Conversation
secretshardul
force-pushed
the
price-impact
branch
from
fc653aa to
83e1f74
Compare
Contributor
Author
|
Merged in cyclos-prod |
smrnjeet222
suggested changes
Oct 11, 2021
|
|
||
| // Use last route item to find impact | ||
| const route = useRoute(fromMint, toMint); | ||
| const impact = usePriceImpact(route?.at(-1)); |
There was a problem hiding this comment.
const impact = usePriceImpact(route?.[route?.length - 1]);Array.at() is experimental and causing issues
|
Looks like this only goes through 1 market - for a transitive swap (A -> B + B -> C) wouldn't you have to sum price impact against both markets? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pseudo-code in #86
Values match with numbers shown by Raydium