Open
Conversation
no longer needed now that the asm logic has been refactored
in party mode it would be pretty annoying if when someone disconnects and it ends the game for everyone. this should allow the game to continue. not fully sure if this is without some desync risk
still feels a little brittle but it should work in most cases
controlled by the server. at the moment the server will never allow items in other modes
for disconnected users we're sort of pretending they are equivalent to our "best" opp. in other words, the opp with the most recent transferred inputs. Before this we weren't doing that quite right and I think it may have been messing with the checksum
if someone disconnected, the inputs to send would get very large very quick. Hopefully this fixes the issue we ran into with the game getting very slow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds party mode. 4 player timed mode FFA with items.