feat: Sorting for replay folders#440
Open
AxisMaen wants to merge 1 commit intoproject-slippi:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes to add a sort button to the left pane of the replay page that toggles the sort order of the folder names and their subdirectories. Picked this up after seeing a very old feature request and also just because I wanted it for myself. This would mainly be useful for people who are organizing their replays into monthly subfolders and need to scroll down to get the most recent replays. This also adjusts the default sort order so those with monthly replay folders will see their most recent replays appear at the top by default.
This is my first time contributing so apologies if I didn't follow any code or PR standards correctly. I'm also definitely open to feedback on the UI and placement of the sort button.
Default sorting:
Toggled sorting (same as the current default):
