Merged
Conversation
YoshiakiNishimura
force-pushed
the
so_separete_log
branch
from
4525b99 to
f882b2e
Compare
There was a problem hiding this comment.
Pull request overview
This pull request centralizes UDF (User-Defined Function) logging prefixes by introducing a new header file and refactoring existing code to use consistent prefix definitions. The changes also modify the behavior when .ini files are found without corresponding .so files.
Changes:
- Introduces a centralized header file (
src/jogasaki/udf/log/logging_prefix.h) that defines UDF logging prefixes - Refactors UDF-related logging across multiple files to use the centralized prefix constants
- Changes behavior to silently skip .ini files without corresponding .so files (previously reported as an error)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/jogasaki/udf/log/logging_prefix.h | New header defining centralized UDF logging prefixes: "[udf] ", "[udf][grpc] ", "[udf in] ", "[udf out] " |
| src/jogasaki/udf/udf_loader.cpp | Adds includes for logging and centralized prefixes; removes error reporting for missing .so files and adds trace logging when .so files are found |
| src/jogasaki/udf/data/udf_any_sequence_stream.cpp | Replaces local udf_out_prefix constant with centralized jogasaki::udf::log::udf_out_prefix |
| src/jogasaki/executor/function/udf_functions.cpp | Replaces local udf_in_prefix and udf_out_prefix constants with centralized versions; replaces "[gRPC]" string literals with grpc_prefix |
| src/jogasaki/api/impl/database.cpp | Replaces "[gRPC]" string literals in UDF load result logging with centralized jogasaki::udf::log::prefix |
| src/CMakeLists.txt | Adds "jogasaki/udf/log/*.cpp" to the build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/project-tsurugi/tsurugi-issues/issues/1395