udf: enable TLS when secure=true using SslCredentials#245
Merged
YoshiakiNishimura merged 1 commit intomasterfrom Feb 26, 2026
Merged
udf: enable TLS when secure=true using SslCredentials#245YoshiakiNishimura merged 1 commit intomasterfrom
YoshiakiNishimura merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables TLS support for UDF (User Defined Function) gRPC communication by implementing the secure configuration option that was previously unsupported. When secure=true is configured in the UDF settings, the system now creates a gRPC channel with SSL credentials instead of rejecting the configuration.
Changes:
- Removed the error that rejected secure=true configurations
- Added conditional logic to use SslCredentials when secure is enabled, or InsecureChannelCredentials when disabled
- The SSL configuration uses default SslCredentialsOptions without custom certificate paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YoshiakiNishimura
force-pushed
the
grpc_ssl_connect
branch
from
30bdb55 to
ce0fded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/project-tsurugi/tsurugi-issues/issues/1399