Skip to content

Conversation

@kblaschke
Copy link
Member

Two fixes for issues reported by @yoyofr:

  • Shader beat/volume values were divided by 100, which basically broke any beat-related code in warp/comp shaders.
  • Added three overloads with int arguments for the custom mult() implementation to properly propagate NaN values as DX9 does.

Required to propagate NaNs as SM3/DX9 does.

Signed-off-by: Kai Blaschke <[email protected]>
Since earlier projectM versions had values in these args which were way higher than they should've been, they were divided by 100. Since the audio processing refactor, this is no longer required, but these divisions were overlooked and thus shaders got only 1% of the actual magnitude expected.

Signed-off-by: Kai Blaschke <[email protected]>
@kblaschke kblaschke added this to the 4.2 milestone Nov 2, 2025
@kblaschke kblaschke self-assigned this Nov 2, 2025
@kblaschke kblaschke added the bug The issue is (potentially) a bug. label Nov 2, 2025
Copy link
Collaborator

@mbaetgen-wup mbaetgen-wup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested...makes quite a difference, looking great!

@kblaschke kblaschke merged commit 48ad458 into projectM-visualizer:master Nov 3, 2025
9 checks passed
@kblaschke kblaschke deleted the bugfixes-yoyofr branch November 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The issue is (potentially) a bug.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants