Skip to content

Add additional workflow configurations, fix some issues #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add additional workflow configurations, fix some issues #923

wants to merge 4 commits into from
+240 −180

Conversation

@kblaschke
Copy link
Member

@kblaschke kblaschke commented Nov 4, 2025

Added additional GitHub Actions workflows to test additional build configurations, e.g.:

  • Using boost::filesystem instead of std::filesystem
  • Build 32-bit binaries on Windows
  • Build on Windows Server 2022 and 2025
  • Build for armv7/x86_64 platforms on Android
  • Build both x86_64 and arm64 binaries on macOS

Fixed a few build issues which popped up on the vcpkg update and adding the additional workflows:

  • Added a missing include in the playlist implementation which broke the build when using MSVC and boost::filesystem
  • Silenced a CMake warning if projectm-eval wasn't found externally
  • Force CMake to use Boost's own CMake config package instead of CMake's internal find module

After merging, I'll cherry-pick those changes into the 4.1.x branch as well and then tag a new 4.1.6 release to fix the build issue.

@kblaschke
Add missing <chrono> include in Playlist.cpp
37a92f6
@kblaschke
Use Boost's own CMake configuration file instead of CMake's module
8df329f 
Otherwise, breaks builds with newer Boost versions. Also set policy CMP0167 to NEW and forcing CMake to use the Config package and not the built-in module. Will now require Boost 1.70, but this should be available everywhere.
@kblaschke
Silence CMake warning if projectM-Eval is not found externally.
537add3 
Also output additional information in both cases (found/not found).
@kblaschke
Add workflow configurations to test boost-filesystem and more platfor…
ebb8b33 
…ms/archs
@kblaschke kblaschke self-assigned this Nov 4, 2025
@kblaschke kblaschke added bug The issue is (potentially) a bug. enhancement The feature is considered an enhancement. cmake The issue is about the CMake build code or an issue with CMake itself in regards to projectM. labels Nov 4, 2025
@kblaschke kblaschke added this to the 4.2 milestone Nov 4, 2025
@kblaschke kblaschke moved this to In Review in libprojectM Release 4.2 Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revmischa revmischa Awaiting requested review from revmischa

@blaquewithaq blaquewithaq Awaiting requested review from blaquewithaq

1 more reviewer

@mbaetgen-wup mbaetgen-wup mbaetgen-wup approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@kblaschke kblaschke

Labels

bug The issue is (potentially) a bug. cmake The issue is about the CMake build code or an issue with CMake itself in regards to projectM. enhancement The feature is considered an enhancement.

Projects

libprojectM Release 4.2
Status: In Review

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@kblaschke @mbaetgen-wup