Migrate resources and UI utils to sharedfeatures for CMP support #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
had a problem deploying
to
staging
GitHub Actions
Failure
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
Move core resources, theme, and UI utilities from android/core/* modules to sharedfeatures/* to enable Compose Multiplatform sharing across Android, iOS, Desktop, and Web targets. - Create sharedfeatures/core-resources with drawable and string resources - Create sharedfeatures/ui-utils with theme, buttons, text fields, and utilities - Update all module dependencies to use new shared module paths - Preserve original app launcher icons (WebP format) in app-newm - Fix investment portfolio title font size (h1 -> h4) - Remove stale android:core:theme module reference from settings Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update imports to use new sharedfeatures module paths: - ToastSideEffect, PrimaryButton -> io.newm.sharedfeatures.ui - TextFieldWithLabel, TextFieldWithLabelDefaults -> io.newm.sharedfeatures.ui.text - Theme colors -> io.newm.sharedfeatures.theme - Resources R -> io.newm.sharedfeatures.core.resources.R - Replace inter font with FontFamily.Default Co-Authored-By: Claude Opus 4.5 <[email protected]>
The original Typography had custom h1 (32sp), h2 (26sp), h3 (22sp), h4 (20sp) definitions. Without these, the default Material h1 (96sp) was being used, causing oversized text on password/reset screens. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Restore original typography appearance by adding custom font files and font family definitions. This fixes the "text too high" issue on the forgot password screen caused by different font metrics between system default fonts and the original custom fonts. Co-Authored-By: Claude Opus 4.5 <[email protected]>
LoadingScreen was in androidMain but is used by commonMain code, causing desktop and wasm builds to fail. The composable only uses standard Compose APIs so it can be shared across all platforms. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Moved sharedfeatures/core-resources to :core-resources - Moved sharedfeatures/ui-utils to :core-ui - Updated all imports to use new package names: - io.newm.core.resources.* for resources - io.newm.core.ui.* for UI components - io.newm.core.ui.theme.* for theme - Updated snapshot baselines for CreateAccountUi and ResetPasswordUi Co-Authored-By: Claude Opus 4.5 <[email protected]>
cristhianescobar
force-pushed
the
cristhian/migrate-resources-to-cmp
branch
from
8f7474b to
4537403
Compare
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
cristhianescobar
temporarily deployed
to
staging
GitHub Actions
Inactive
newmskywalker
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
android/core/*modules tosharedfeatures/*to enable Compose Multiplatform sharing across Android, iOS, Desktop, and Web targetssharedfeatures/core-resourceswith drawable and string resourcessharedfeatures/ui-utilswith theme, buttons, text fields, and utilitiesandroid:core:thememodule reference from settingsTest plan
./gradlew spotlessApply- passes./gradlew :sharedfeatures:test :shared:test- passes./gradlew :sharedfeatures:verifyPaparazziDebug- passes🤖 Generated with Claude Code