Conversation
b9f4dd4 to
46ec421
Compare
seanaery
left a comment
There was a problem hiding this comment.
This is great - thanks for working through these changes! I see that the three test environments in CI are all now using BL9 and all have passing tests. I can get the app to run without error now using this branch. The UI will definitely need some subsequent work to catch up to all the BL9 changes :-)
|
@seanaery did you have any particular issues or changes in mind when you mentioned:
|
|
@corylown I did -- mostly some obvious visible layout issues, but there's also probably some under-the-hood refactoring to do, like switching to using CSS custom properties (variables) instead of Sass variables. And now that BL9 fixes native advanced search, I want to ensure that a newly-generated arclight app's advanced search "just works." I'll aim to make some tickets today that include screenshots. |
Includes much of #1628
Drops Blacklight 8