redirects to main_app.root_url when folder id is invalid#103
Open
jiaola wants to merge 1 commit intoprojectblacklight:masterfrom
Open
redirects to main_app.root_url when folder id is invalid#103jiaola wants to merge 1 commit intoprojectblacklight:masterfrom
jiaola wants to merge 1 commit intoprojectblacklight:masterfrom
Conversation
Contributor
|
Would it be better to go to folders index instead of app home? |
Member
|
Rails catches the RecordNotFound errors in production mode and shows a 404 page. https://github.com/rails/rails/blob/504e5e102b847019f08c4c2d1fa30444ed9a59a0/railties/test/application/middleware/exceptions_test.rb#L35-L46 So we probably don't want your PR to prevent that from happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a problem a user tries to access a folder that doesn't exist or has been deleted. It throws an error: ActiveRecord::RecordNotFound in Blacklight::Folders::FoldersController#show
We'd like to catch this error, redirect to root_url with a helpful message. This fix does that.
This is a resubmit of the previous pull request #98