Conversation
159937b to
23a0367
Compare
23a0367 to
133830b
Compare
|
I'm very novice at docker/docker-compose. Woudl it make sense to add something to README in the testing section. Currently it says (perhaps already out of date),
(Is that still all that you need to do to run tests?) With different paths in "local testing" sub-section too. https://github.com/projectblacklight/blacklight_range_limit?tab=readme-ov-file#tests Can someone that understands better make sure that's all accurate and up to date and all anyone needs to know to run tests with this PR, before merging? Thank you! |
|
@jrochkind yes, that's all you need to do. This is the same approach used by blacklight core. |
|
Thanks! I will try testing it, since I am having trouble getting tests to run locally in master, but I may not be able to get it to work for similar unrelated reasons. Also, perhaps a note you need Docker or equivalent (I am not sure what equivalents might be) installed and running? That is a difference as of this PR? |
|
OK, I think maybe the instructions in README in Local testing are already out of date and don't work maybe? Very confused about what's going on in testing world and how to get local testing to work! https://github.com/projectblacklight/blacklight_range_limit?tab=readme-ov-file#local-testing
|
fbedeab to
7f7dc5e
Compare
No description provided.