Skip to content

Lock to bundler < 4 to fix CI #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrochkind merged 3 commits into from
Jan 6, 2026
Merged

Lock to bundler < 4 to fix CI #328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c12c00
Run CI on BL 7 with Bundler 2.7 -- BL7 generator uses Bundler.with_cl…
jrochkind Dec 9, 2025
fc61bea
update CI for Rails 8.1.0 to not specify rc, which makes it more read…
jrochkind Dec 9, 2025
a37f0ff
lock bundler to <4 in CI for now, engine_cart incompatibility
jrochkind Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ jobs:
# BLACKLIGHT EDGE, can test with latest rails, importmap and esbuild
#

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: 'https://github.com/projectblacklight/blacklight.git'
ruby: "3.3"
additional_name: "/ importmap-rails"
additional_engine_cart_rails_options: "--css=bootstrap"

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: 'https://github.com/projectblacklight/blacklight.git'
ruby: "3.3"
additional_name: "/ esbuild"
Expand All @@ -57,13 +57,13 @@ jobs:
# BLACKLIGHT 9 and with Rails 8 and 8.1
#

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: '~> 9.0'
ruby: "3.4"
additional_name: "/ importmap-rails"
additional_engine_cart_rails_options: "--css=bootstrap"

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: '~> 9.0'
ruby: "3.4"
additional_name: "/ esbuild"
Expand All @@ -85,13 +85,13 @@ jobs:
# BLACKLIGHT 8, can test with use importmaps and esbuild, also rails 8 and 8.1
# and a bit of 7.2

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: "~> 8.0"
ruby: "3.3"
additional_name: "/ importmap-rails, propshaft"
additional_engine_cart_rails_options: "-a propshaft --css=bootstrap"

- rails_version: "~> 8.1.0.rc1"
- rails_version: "~> 8.1.0"
blacklight_version: "~> 8.0"
ruby: "3.3"
additional_engine_cart_rails_options: "-a propshaft --javascript=esbuild --css=bootstrap"
Expand Down Expand Up @@ -131,24 +131,29 @@ jobs:


# BLACKLIGHT 7, only test with esbuild, not sure if it supports importmaps, it won't generate it
# Blacklight 7 generator uses old `Bundler.with_clean_env`, so needs a bundler < 4. (there is no
# bundler 3!)

- rails_version: "7.2.1"
blacklight_version: "~> 7.0"
ruby: "3.3"
additional_engine_cart_rails_options: "--javascript=esbuild"
additional_name: "/ esbuild, sprockets"
bundler: "2.7.2"

- rails_version: "7.2.1"
blacklight_version: "~> 7.0"
ruby: "3.3"
additional_engine_cart_rails_options: "--javascript=esbuild --css=bootstrap -a propshaft"
additional_name: "/ esbuild, propshaft"
bundler: "2.7.2"

- rails_version: "7.1.4"
blacklight_version: "~> 7.0"
ruby: "3.2"
additional_engine_cart_rails_options: "--javascript=esbuild"
additional_name: "/ esbuild, sprockets"
bundler: "2.7.2"


env:
Expand All @@ -161,7 +166,10 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: "latest"
#bundler: ${{ matrix.bundler != '' && matrix.bundler || 'latest' }}
# Bundler locked to <4, see https://github.com/projectblacklight/blacklight_range_limit/pull/328
bundler: ${{ matrix.bundler != '' && matrix.bundler || '2.7.2' }}


- name: Install dependencies
run: bundle install
Expand Down