project.conf: Add x86_64_v3 option and enable it by default#91
project.conf: Add x86_64_v3 option and enable it by default#91
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option to enable x86_64-v3 architecture support within the project. By default, this feature will be active, streamlining the adoption of this specific instruction set architecture. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new build option x86_64_v3 and enables it by default. While the option is correctly defined, it appears to be unused in the project, making it effectively dead code. My review includes a comment to address this by either adding its usage or removing it for now to maintain code clarity.
04addf1 to
27e0562
Compare
|
For some reason, we are building the non-v3 version still |
ee7ca6c to
f30ed24
Compare
f30ed24 to
9344172
Compare
No description provided.