Libcalico-go: Prevent segfault when network/ip is not valid#11084
Open
bartekzurawski wants to merge 1 commit intoprojectcalico:masterfrom
Open
Libcalico-go: Prevent segfault when network/ip is not valid#11084bartekzurawski wants to merge 1 commit intoprojectcalico:masterfrom
bartekzurawski wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
Member
|
@bartekzurawski thanks for providing the fix. Can you also include a unit test for it? |
bartekzurawski
force-pushed
the
net_parsing
branch
from
2989002 to
c6e01dc
Compare
Contributor
Author
|
@mazdakn I've put some test for that change. Can you check? |
|
This PR is stale because it has been open for 60 days with no activity. |
fasaxc
added
docs-not-required
caseydavenport
added
the
release-note-not-required
marvin-tigera
removed
the
release-note-required
Member
|
/sem-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a GlobalNetworkPolicy is created using the internal API group crd.projectcalico.org/v1, invalid CIDRs/IPs are not rejected. The conversion logic in libcalico-go then produces a nil *net.IPNet. Later, when Typha (or Felix) dereferences this pointer (e.g. in model.Rule.String()), a segfault occurs.
This PR changes:
nilcheck to avoid segfaultnil *net.IPNetNormally users should not create objects via
crd.projectcalico.org/v1, the supported API isprojectcalico.org/v3, which performs proper validation. This change just makes the system more robust against unexpected nils.Related issues/PRs
fixes #7697
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.