Skip to content

Conversation

@coutinhop
Copy link
Member

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@coutinhop coutinhop requested a review from lwr20 January 20, 2026 00:02
@coutinhop coutinhop self-assigned this Jan 20, 2026
@coutinhop coutinhop requested a review from a team as a code owner January 20, 2026 00:02
Copilot AI review requested due to automatic review settings January 20, 2026 00:02
@coutinhop coutinhop added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Jan 20, 2026
@marvin-tigera marvin-tigera added this to the Calico v3.32.0 milestone Jan 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Semaphore CI Windows end-to-end pipeline to run on Azure provisioners (primarily azr-aso) instead of the previous AWS/GCP/Rancher-based runs.

Changes:

  • Replaces existing Windows E2E job matrix with azr-aso-based runs.
  • Removes Windows Server 1809 coverage and “no encapsulation” variants, standardizing on Windows Server 2022 + VXLAN.
  • Leaves an azr-aks Windows job scaffold in comments (currently disabled).

Comment on lines 45 to 46
# azr-aso, 2022, stable-3, nftables, vxlan
# azr-aks, 2022, stable-1, iptables, vxlan
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Runs" matrix comments don’t match the actual jobs defined below: the comment lists an azr-aso stable-3 nftables run and an azr-aks iptables run, but the pipeline currently defines only azr-aso stable (BPF) and azr-aso stable-1 (nftables), and the azr-aks job is commented out. Please reconcile the comments with the jobs (or update the jobs to match the intended matrix) to avoid accidentally running the wrong coverage.

Suggested change
# azr-aso, 2022, stable-3, nftables, vxlan
# azr-aks, 2022, stable-1, iptables, vxlan
# azr-aso, 2022, stable-1, nftables, vxlan
# azr-aks, 2022, stable-1, nftables, vxlan

Copilot uses AI. Check for mistakes.
# - name: K8S_VERSION
# value: stable-1
# - name: DATAPLANE
# value: CalicoNftables
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This azr-aks job is currently commented out, and its internal settings are inconsistent: the name says "iptables" but DATAPLANE is set to CalicoNftables. If this block is meant to be used later, update the name and/or DATAPLANE so they agree (and consider removing the block entirely if it’s not intended to be re-enabled).

Suggested change
# value: CalicoNftables
# value: CalicoIptables

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants