Add bpfIPFragTimeout configuration option #11726
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add bpfIPFragTimeout to felixconfiguration
Add bpfIPFragTimeout configuration option
Jan 26, 2026
tomastigera
reviewed
Jan 26, 2026
| // [Default: Auto - read from net.ipv4.ipfrag_time] | ||
| // +kubebuilder:validation:Type=string | ||
| // +kubebuilder:validation:Pattern=`^([0-9]+(\\.[0-9]+)?(ms|s|m|h)|Auto)*$` | ||
| BPFIPFragTimeout *metav1.Duration `json:"bpfIPFragTimeout,omitempty" configv1timescale:"seconds"` |
Contributor
There was a problem hiding this comment.
@copilot how would the metav1.Duration accept "Auto" ? Is it enough to let it unset instead of using Auto?
Contributor
Author
There was a problem hiding this comment.
You're correct - metav1.Duration doesn't accept "Auto" as a value. I've removed "Auto" from the validation pattern and updated the documentation to clarify that leaving the field unset (nil) triggers auto-detection from /proc/sys/net/ipv4/ipfrag_time. Fixed in a42bed4.
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
tomastigera
requested changes
Jan 26, 2026
Contributor
tomastigera
left a comment
tomastigera
left a comment
There was a problem hiding this comment.
remove changes to files in cni-plugin/ those are unrelated
_codeql_detected_source_root
Outdated
Co-authored-by: tomastigera <49207409+tomastigera@users.noreply.github.com>
Contributor
Author
Removed unrelated cni-plugin changes in 13fa293. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Plan for bpfIPFragTimeout
BPFIPFragTimeoutfield to API FelixConfigurationSpec (api/pkg/apis/projectcalico/v3/felixconfig.go)BPFIPFragTimeoutto Felix config struct (felix/config/config_params.go)felix/bpf-gpl/globals.h)felix/bpf/libbpf/libbpf_common.go)felix/bpf/libbpf/libbpf_api.h)felix/bpf/libbpf/libbpf.go)felix/bpf/tc/attach.go)/proc/sys/net/ipv4/ipfrag_timewhen unsetfelix/dataplane/driver.go,felix/dataplane/linux/int_dataplane.go)make generate)Summary
Successfully implemented bpfIPFragTimeout configuration option for Felix. The option:
net.ipv4.ipfrag_timewhen left unset (nil)All automated checks passed successfully. Removed unrelated changes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.