Add make get-operator-crds to ci-preflight-checks#12090
Add make get-operator-crds to ci-preflight-checks#12090MichalFupso wants to merge 1 commit intoprojectcalico:release-v3.30from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates CI preflight checks to include refreshing the tigera-operator CRDs so PRs fail early when operator-generated files would otherwise be marked dirty during the hashrelease workflow.
Changes:
- Add
make get-operator-crdsto theci-preflight-checkstarget. - Update downloaded tigera-operator CRDs (adds a degraded “Message” printer column; marks
nonPrivilegedas deprecated via schema description text).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Makefile |
Runs get-operator-crds as part of CI preflight so generated CRDs are validated as clean before hashrelease. |
charts/tigera-operator/crds/operator.tigera.io_tigerastatuses_crd.yaml |
Adds an additional printer column to surface the degraded condition message. |
charts/tigera-operator/crds/operator.tigera.io_installations_crd.yaml |
Updates the OpenAPI schema description for nonPrivileged to indicate deprecation and unsupported usage. |
You can also share your feedback on Copilot code review. Take the survey.
| $(MAKE) check-dockerfiles | ||
| $(MAKE) check-language | ||
| $(MAKE) generate | ||
| $(MAKE) get-operator-crds | ||
| $(MAKE) fix-all |
There was a problem hiding this comment.
ci-preflight-checks now runs get-operator-crds, but the get-operator-crds recipe currently loops over multiple curl downloads without set -e/error aggregation. In POSIX sh, a failure in an early loop iteration won’t necessarily fail the overall for loop (the loop exits with the status of the last iteration), so CI can pass while one or more CRDs were not refreshed. Consider updating get-operator-crds to fail fast on any download error (e.g., enable set -e for the whole recipe or explicitly exit 1 on failed curl), and optionally add curl --retry ... to reduce transient network flakes.
|
@MichalFupso we used to have this, but removed it based on a discussion with @fasaxc - so you guys should chat :p |
Add a get-operator-crds to make ci-preflight-checks. This was causing issues with hashreleases where during PR we did not check for the generated files, but that target was run during hashrelease job. This would fail hashrelease as the files were marked as dirty
Release note: