[refactor] vpp-manager rework #853
Conversation
Signed-off-by: Nathan Skrzypczak <[email protected]>
sknat
force-pushed
the
refact-vpp-manager
branch
from
608e6ad to
2e2237b
Compare
| return &AFXDPDriver{ | ||
| UplinkDriverData: UplinkDriverData{ | ||
| name: NativeDriverAfXdp, | ||
| params: params, | ||
| intf: intf, | ||
| }, |
There was a problem hiding this comment.
Shouldn't we also set conf here in the constructor? --> "conf: intf.State,"
This applies to all the drivers under vpp-manager/uplink. Various methods in the driver code read from d.conf, so without setting conf: intf.State, won't those function calls lead to an error?
| } | ||
| intf.State = uplinkState | ||
| intf.Driver = uplink.NewUplinkDriver( | ||
| intf.Driver.GetName(), |
There was a problem hiding this comment.
Won't this fail because when VppManagerInterface starts, there is no Driver instance yet? Here, we are creating that instance with NewUplinkDriver and we should be passing the configured driver name from the spec intf.Spec.VppDriver instead of intf.Driver.GetName().
| PreconfigureLinux() error | ||
| CreateMainVppInterface(vpp *vpplink.VppLink, vppPid int, uplinkSpec *UplinkInterfaceSpec) error | ||
| RestoreLinux() | ||
| IsSupported(warn bool) bool |
There was a problem hiding this comment.
Unrelated to this PR, but this function for the AF_XDP driver seems to be broken. It is always returning false!
2 participants
No description provided.