fix: support for service account bound tokens expiration #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
approved these changes
Nov 11, 2024
Member
prometherion
left a comment
prometherion
left a comment
There was a problem hiding this comment.
Thanks for the prompt fix, I really appreciated it! 💯
Member
|
@ppodevlabs please, may I ask you to rebase this to get it merged? Thanks! |
pepordev
force-pushed
the
fix/support-bound-token-expiration
branch
from
c04a43b to
a0b22b7
Compare
…ojectcapsule#554) Bumps [zgosalvez/github-actions-ensure-sha-pinned-actions](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions) from 3.0.14 to 3.0.15. - [Release notes](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/releases) - [Commits](zgosalvez/github-actions-ensure-sha-pinned-actions@40ba2d5...ed00f72) --- updated-dependencies: - dependency-name: zgosalvez/github-actions-ensure-sha-pinned-actions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Pedro Parra Ortega <[email protected]>
Signed-off-by: Pedro Parra Ortega <[email protected]> chore: added missing file Signed-off-by: Pedro Parra Ortega <[email protected]> chore: lint Signed-off-by: Pedro Parra Ortega <[email protected]> chore: lint file Signed-off-by: Pedro Parra Ortega <[email protected]>
pepordev
force-pushed
the
fix/support-bound-token-expiration
branch
from
a4d4450 to
245b6a5
Compare
Signed-off-by: Pedro Parra Ortega <[email protected]>
Signed-off-by: Pedro Parra Ortega <[email protected]>
…ch-labs/capsule-proxy into fix/support-bound-token-expiration
Contributor
Author
|
closing this one, i'll create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
From kubernetes 1.30 kubelet takes care of renewing tokens for service accounts inside the projected volumes. This PR make capsule-proxy to reload the token when required.