Fix: Feature / Question: go-tree-sitter dependency#1551
Open
adrianfolkeson wants to merge 3 commits intoprojectdiscovery:mainfrom
Open
Fix: Feature / Question: go-tree-sitter dependency#1551adrianfolkeson wants to merge 3 commits intoprojectdiscovery:mainfrom
adrianfolkeson wants to merge 3 commits intoprojectdiscovery:mainfrom
Conversation
…discovery#1506) * Fix: Prioritize -cwu over -headless flag When both -cwu (Chrome WebSocket URL) and -headless flags are used together, -cwu should take precedence since the user explicitly wants to connect to an existing browser session. Without this fix, when users run: katana -headless -u URL -cwu ws://... -no-incognito The -headless flag causes Katana to launch a new Chrome instance, completely ignoring the -cwu WebSocket URL. This makes authenticated crawling via existing browser sessions impossible when following the official documentation. Changes: - Prioritize ChromeWSUrl check in engine selection (runner.go) - Add warning when -headless is used with -cwu (options.go) - Ensure hybrid engine is selected when -cwu is specified This fix maintains backward compatibility while making the documented workflow actually work as intended. Fixes issue where -cwu flag is ignored when -headless is present. * chore(runner): rm logs --------- Co-authored-by: aparsons2 <adam_parsons@intuit.com> Co-authored-by: Dwi Siswanto <25837540+dwisiswant0@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1367 regarding cross-platform compilation issues. We've swapped out the
go-tree-sitterdependency (which required CGO) for a pure-Go alternative. This simplifies our build pipeline significantly, especially for macOS/ARM64 builds, by removing the need for external C compilers. The parsing logic has been updated to match the new library's API while maintaining existing functionality. /claim