Skip to content

Sort sources alphabetically#1720

Merged
dogancanbakir merged 2 commits intoprojectdiscovery:devfrom
PontusLindblom:fix/sources-in-alphabetical-order
Feb 4, 2026
Merged

Sort sources alphabetically#1720
dogancanbakir merged 2 commits intoprojectdiscovery:devfrom
PontusLindblom:fix/sources-in-alphabetical-order

Conversation

@PontusLindblom
Copy link
Contributor

@PontusLindblom PontusLindblom commented Jan 29, 2026

Ensure the order of the -ls output matches provider-config.yaml to avoid confusion when comparing them.

Closes #1721

Summary by CodeRabbit

  • New Features

    • Added several new passive data providers to the sources list.
  • Improvements

    • Reordered and cleaned up the passive sources sequence for clearer prioritization and consistency.
    • Introduced deliberate placeholder/disabled entries to preserve known-but-inactive providers and clarify intent.
  • Chores

    • No public API or exported signatures were changed.

Ensure the order of -ls matches provider-config.yaml to
avoid confusion when comparing them.
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Walkthrough

Updates the exported AllSources slice in the passive sources module: adds several new providers, reorders many entries, and leaves some providers commented/placeholdered. No public API signatures were changed.

Changes

Cohort / File(s) Summary
Passive Sources
pkg/passive/sources.go
Modified the exported AllSources slice: added new sources (e.g., builtwith, digitalyama, facebook, hudsonrock, leakix, profundis, quake, thc, reconeer), reordered multiple entries (e.g., domainsproject moved after dnsrepo, adjustments to netlas/leakix/profundis/quake positions), and retained/commented placeholder providers. No API signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through lists both old and new,
I nudged sources left, and nudged a few,
Order adjusted, placeholders kept in view,
APIs untouched — a tidy little cue,
A rabbit’s hop to keep the catalog true.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Sort sources alphabetically' directly matches the main objective stated in issue #1721 and accurately describes the primary change in the pull request.
Linked Issues check ✅ Passed The PR successfully addresses the linked issue #1721 by sorting sources alphabetically in the AllSources list as required to match provider-config.yaml ordering.
Out of Scope Changes check ✅ Passed All changes in pkg/passive/sources.go are directly related to reordering and managing the AllSources list to achieve alphabetical sorting, which is within scope of the linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir
Copy link
Member

@coderabbitai create an issue for this

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@dogancanbakir I'll create an issue to track this.


🏁 Script executed:

#!/bin/bash
# Create a GitHub issue for tracking the sources alphabetical sorting work

gh issue create \
  --title "Sort sources alphabetically to match provider-config.yaml" \
  --body "Ensure the order of the -ls output matches provider-config.yaml to avoid confusion when comparing them.

**Related PR:** https://github.com/projectdiscovery/subfinder/pull/1720
**Requested by:** `@dogancanbakir`" \
  --assignee dogancanbakir

Length of output: 57


@dogancanbakir I've created issue #1721 to track this work: #1721

The issue has been assigned to you and includes a reference to this PR.

Copy link
Contributor

@Jigardjain Jigardjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: APPROVE

Reasons to merge:

  1. Zero risk - Pure code organization, no functional changes
  2. Improves UX - Makes it easier to compare -ls output with config files
  3. Better maintainability - Future contributors will find sources easier
  4. Clean implementation - Simple, straightforward change

This is a safe, low-risk quality-of-life improvement that should be merged.
@dogancanbakir

@Jigardjain
Copy link
Contributor

@PontusLindblom, This PR is good to go. But just one important thing you need to rebase this PR to the latest dev branch.

Resolve conflict by adding urlscan source in alphabetical order.
@dogancanbakir dogancanbakir force-pushed the fix/sources-in-alphabetical-order branch from 76019b1 to ab19329 Compare February 4, 2026 12:04
@dogancanbakir dogancanbakir merged commit a349b9e into projectdiscovery:dev Feb 4, 2026
10 checks passed
@PontusLindblom PontusLindblom deleted the fix/sources-in-alphabetical-order branch February 4, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort sources alphabetically to match provider-config.yaml

3 participants