Skip to content

Remove dead facebook source (#1727)#1732

Open
PontusLindblom wants to merge 1 commit intoprojectdiscovery:devfrom
PontusLindblom:chore/remove-dead-source
Open

Remove dead facebook source (#1727)#1732
PontusLindblom wants to merge 1 commit intoprojectdiscovery:devfrom
PontusLindblom:chore/remove-dead-source

Conversation

@PontusLindblom
Copy link
Contributor

@PontusLindblom PontusLindblom commented Feb 7, 2026

The Meta CT API has been discontinued.

Closes #1727

Proposed changes

Remove all code related to Facebook, as the source is officially discontinued.

Proof

See images for results before and after the change.

-ls before
Subfinder_ls_1

-ls after
Subfinder_ls_2

-s facebook before
Subfinder_run_1

-s facebook after
Subfinder_run_2

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • Chores
    • Removed the Facebook source from the application's available data sources and initialization configuration. This data source is no longer available for selection during runtime. Related test files and expectations have been updated accordingly.

The Meta CT API has been discontinued.
@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

Walkthrough

This change removes the Facebook source from subfinder's passive reconnaissance sources. The Facebook Certificate Transparency API has been discontinued by Meta, making the source non-functional. All related implementation files, imports, registry entries, tests, and type definitions are deleted.

Changes

Cohort / File(s) Summary
Source Registry
pkg/passive/sources.go, pkg/passive/sources_test.go
Removed Facebook source import and its entry from the AllSources, DefaultSources, and DefaultRecursiveSources lists. Test expectations updated to reflect the removal.
Facebook Source Implementation
pkg/subscraping/sources/facebook/ctlogs.go, pkg/subscraping/sources/facebook/ctlogs_test.go, pkg/subscraping/sources/facebook/types.go
Removed entire Facebook CT logs source implementation including the apiKey and Source types with all associated methods (Run, Name, IsDefault, HasRecursiveSupport, KeyRequirement, NeedsKey, AddApiKeys, Statistics). Deleted all type definitions for API response parsing and the corresponding integration test.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Farewell, Facebook, you've had your day,
Your CT logs have gone away,
Meta discontinued, we must move on,
Your source code vanishes at dawn!
Five files deleted, clean and clear,
Subfinder marches forward here! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove dead facebook source (#1727)' clearly and concisely describes the main change of removing the Facebook source from the codebase, matching the changeset contents.
Linked Issues check ✅ Passed The PR successfully fulfills issue #1727 requirements by completely removing all Facebook source code (ctlogs.go, types.go, tests) and its references from the sources list and test expectations.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to removing the Facebook source; no unrelated modifications or out-of-scope changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir
Copy link
Member

Hi, thanks for your interest in contributing! Just a heads up, we ask contributors to work on 1 active issue at a time (see).

Also, we welcome AI-assisted development, but submissions must be complete, tested, and ready to merge. Please also make sure to fill out the PR template with proof that your changes work.

We're closing this PR along with your other open submissions. Once you're ready, feel free to pick one issue to focus on and resubmit; we'd be happy to review it.

Appreciate your understanding!

@PontusLindblom
Copy link
Contributor Author

Hi @dogancanbakir,
I'm sorry that I opened two PRs (this and Chore - Update workflow dependencies) at the same time. I thought they were reasonably simple, non-related changes that could be solved at the same time.

If possible, could you please reopen this PR? My changes are 100% manual (no AI), and I put considerable effort into making this a clean PR for you to review.

@dogancanbakir dogancanbakir reopened this Feb 16, 2026
@dogancanbakir
Copy link
Member

Sorry about that — this was closed by mistake. Reopened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove facebook source (Meta CT API discontinued)

2 participants