Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions pkg/passive/passive.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,7 @@ func (a *Agent) buildMultiRateLimiter(ctx context.Context, globalRateLimit int,
var multiRateLimiter *ratelimit.MultiLimiter
var err error
for _, source := range a.sources {
var rl uint
if sourceRateLimit, ok := rateLimit.Custom.Get(strings.ToLower(source.Name())); ok {
rl = sourceRateLimitOrDefault(uint(globalRateLimit), sourceRateLimit)
}
rl := resolveSourceRateLimit(globalRateLimit, rateLimit, source.Name())

if rl > 0 {
multiRateLimiter, err = addRateLimiter(ctx, multiRateLimiter, source.Name(), rl, time.Second)
Expand All @@ -104,6 +101,23 @@ func (a *Agent) buildMultiRateLimiter(ctx context.Context, globalRateLimit int,
return multiRateLimiter, err
}

func resolveSourceRateLimit(globalRateLimit int, rateLimit *subscraping.CustomRateLimit, sourceName string) uint {
defaultRateLimit := uint(0)
if globalRateLimit > 0 {
defaultRateLimit = uint(globalRateLimit)
}

if rateLimit == nil {
return defaultRateLimit
}

if sourceRateLimit, ok := rateLimit.Custom.Get(strings.ToLower(sourceName)); ok {
return sourceRateLimitOrDefault(defaultRateLimit, sourceRateLimit)
}

return defaultRateLimit
}

func sourceRateLimitOrDefault(defaultRateLimit uint, sourceRateLimit uint) uint {
if sourceRateLimit > 0 {
return sourceRateLimit
Expand Down
72 changes: 72 additions & 0 deletions pkg/passive/passive_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package passive

import (
"testing"

"github.com/projectdiscovery/subfinder/v2/pkg/subscraping"
mapsutil "github.com/projectdiscovery/utils/maps"
)

func TestResolveSourceRateLimit(t *testing.T) {
customRates := &subscraping.CustomRateLimit{
Custom: mapsutil.SyncLockMap[string, uint]{
Map: map[string]uint{
"sitedossier": 2,
"github": 0,
},
},
}

testCases := []struct {
name string
globalRateLimit int
customRates *subscraping.CustomRateLimit
sourceName string
expected uint
}{
{
name: "uses global rate limit when no custom map is provided",
globalRateLimit: 5,
customRates: nil,
sourceName: "sitedossier",
expected: 5,
},
{
name: "uses global rate limit when source is not in custom map",
globalRateLimit: 7,
customRates: customRates,
sourceName: "shodan",
expected: 7,
},
{
name: "uses source specific override when present",
globalRateLimit: 7,
customRates: customRates,
sourceName: "sitedossier",
expected: 2,
},
{
name: "treats zero custom limit as fallback to global",
globalRateLimit: 9,
customRates: customRates,
sourceName: "github",
expected: 9,
},
{
name: "stays unlimited when no global or custom rate is configured",
globalRateLimit: 0,
customRates: customRates,
sourceName: "waybackarchive",
expected: 0,
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
actual := resolveSourceRateLimit(tc.globalRateLimit, tc.customRates, tc.sourceName)
if actual != tc.expected {
t.Fatalf("expected %d, got %d", tc.expected, actual)
}
})
}
}