feat: improve LongestRepeatingSequence performance by reducing allocs #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Uses an optimization to keep only two arrays + other misc changes. Benchmarks: $ go test -bench=. -benchmem -memprofile=allocs goos: darwin goarch: amd64 pkg: github.com/projectdiscovery/utils/strings cpu: VirtualApple @ 2.50GHz BenchmarkLongestRepeatingSequence-10 171566 6612 ns/op 15584 B/op 61 allocs/op BenchmarkLongestRepeatingSequenceNew-10 360710 3129 ns/op 704 B/op 2 allocs/op +++ PASS ok github.com/projectdiscovery/utils/strings 1.851s
Ice3man543
changed the title
Mzack9999
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an optimization to keep only two arrays + other misc changes
Benchmarks: