Skip to content

feat: add swissmap #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dwisiswant0 wants to merge 18 commits into from
Closed

feat: add swissmap #624

dwisiswant0 wants to merge 18 commits into from

Conversation

@dwisiswant0
Copy link
Member

@dwisiswant0 dwisiswant0 commented Feb 4, 2025 •
edited
Loading

@dwisiswant0
feat: add swissmap
7a8e7f0 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
test(maps): add bench test
5b9371c 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0 dwisiswant0 requested a review from Mzack9999 February 4, 2025 22:51
@dwisiswant0
chore(swissmap): add BENCHMARK.md
99d911f 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
test(swissmap): missing WithThreadSafety opt in concurrent ops
57fc90d 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): implements JSON marshal/unmarshaller
8b86421 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): add WithSortMapKeys option
72ef9f3 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): update Map type constraints to ComparableOrdered …
de970a2 
…& `any`

Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): add key tracking & GetByIndex method
1ced316 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
fix(swissmap): Map.Set deadlock
5cf4990 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
chore(swissmap): autofix field alignment
2f05f0c 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
perf(swissmap): reuse existing slice cap
dfee101 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): deferred unlocks
ac1f5df 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): prealloc Map.keys within WithCapacity
4a3fb62 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
chore(swissmap): WithThreadSafety -> WithConcurrentAccess
600cf9a 
and `m.threadSafe` -> `m.concurrent`

Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): get Map.keys conditionally
b190f59 
and prealloc those

Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
feat(swissmap): rm reads locker
1d599fa 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
chore(swissmap): add .gitignore
b1ea180 
Signed-off-by: Dwi Siswanto <[email protected]>
@dwisiswant0
chore(swissmap): add bench script & update test
1ce1825 
Signed-off-by: Dwi Siswanto <[email protected]>
Mzack9999
Mzack9999 requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests

@Mzack9999
Copy link
Member

Mzack9999 commented Aug 15, 2025

@dwisiswant0 I'm closing the PR as swissmap is now the default implementation of map in go 1.24 if I'm not mistaken

@Mzack9999 Mzack9999 closed this Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwisiswant0 @Mzack9999