Use built-in rand v2

.github/workflows/build-test.yml

@@ -5,8 +5,18 @@ on:
   workflow_dispatch:
 
 jobs:
+  lint:
+    name: "Lint"
+    if: "${{ !endsWith(github.actor, '[bot]') }}"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: projectdiscovery/actions/setup/go@v1
+      - uses: projectdiscovery/actions/golangci-lint@v1
+
   build:
     name: Test Builds
+    needs: ["lint"]
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:

ml/model_selection/model_selection.go

@@ -1,7 +1,7 @@
 package modelselection
 
 import (
-	"math/rand"
+	"math/rand/v2"
 )
 
 func TrainTestSplit(dataset []interface{}, testSize float64) (train, test []interface{}) {

rand/number.go

@@ -4,7 +4,7 @@ import (
 	"crypto/rand"
 	"errors"
 	"math/big"
-	crand "math/rand"
+	crand "math/rand/v2"
 )
 
 // IntN returns a uniform random value in [0, max). It errors if max <= 0.
@@ -14,7 +14,7 @@ func IntN(max int) (int, error) {
 	}
 	nBig, err := rand.Int(rand.Reader, big.NewInt(int64(max)))
 	if err != nil {
-		return crand.Intn(max), nil
+		return crand.IntN(max), nil
 	}
 	return int(nBig.Int64()), nil
 }

regexp/regexp.go

@@ -98,7 +98,7 @@ func compileWithRE2(pattern string) (*Regexp, error) {
 		os.Stderr = devNull
 		defer func() {
 			os.Stderr = originalStderr
-			devNull.Close()
+			_ = devNull.Close()
 		}()
 	}
 

slice/sliceutil.go

@@ -1,7 +1,7 @@
 package sliceutil
 
 import (
-	"math/rand"
+	"math/rand/v2"
 	"strconv"
 	"time"
 
@@ -61,7 +61,7 @@ func DedupeFunc[T any](inputSlice []T, keyFunc func(T) any) (result []T) {
 
 // PickRandom item from a slice of elements
 func PickRandom[T any](v []T) T {
-	return v[rand.Intn(len(v))]
+	return v[rand.IntN(len(v))]
 }
 
 // Contains if a slice contains an element