refactor(errorutil): impl proper err wrapping w/ stdlib compat #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `wrappedErr` field to `enrichedError` to maintain error chains. * implement `Unwrap()` method to supports builtin `errors.Is`/`errors.As`. * refactor `Wrap()` method to preserve err chains instead of str concat. * update `NewWithErr()` to properly wrap errors while preserving tags & stacktrace. * enhance `Equal()` method to check wrapped error chains using `errors.Is`. * improve `IsAny()` func to use bidirectional `errors.Is` checking. so basically these changes enable runtime type assertion via builtin `errors.Is`/`errors.As` func for granular error handling in call stacks while maintaining backward compatibility w/ existing enriched error feats. Signed-off-by: Dwi Siswanto <[email protected]>
Mzack9999
approved these changes
Jul 18, 2025
Mzack9999
deleted the
dwisiswant0/refactor/errorutil/impl-proper-err-wrapping-w-stdlib-compat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on projectdiscovery/nuclei#6326
changes:
wrappedErrfield toenrichedErrorto maintain error chains.Unwrap()method to supports builtinerrors.Is/errors.As.Wrap()method to preserve err chains instead of str concat.NewWithErr()to properly wrap errors while preserving tags & stacktrace.Equal()method to check wrapped error chains usingerrors.Is.IsAny()func to use bidirectionalerrors.Ischecking.so basically these changes enable runtime type assertion via builtin
errors.Is/errors.Asfunc for granular error handling in call stacks while maintaining backward compatibility w/ existing enriched error feats.