Iterate over all fingerprint patterns, fixes #138 #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now,
matchKeyValueString
andmatchMapString
iterated over fingerprint patterns in non deterministic order because some parsed fingerprint patterns (for example headers) are parsed into amap
type. Since also these functions iterated over patterns until a first match, it could return different version upon each run (described in issue #138).With this change:
confidences
, I choose a maximum value because from my understanding of the rest of the code any non-zero confidence value automatically flags the discovery as valid anyway.