feat: various caching & memory optimizations#222
Draft
Snazzah wants to merge 11 commits intoprojectdysnomia:devfrom
Draft
feat: various caching & memory optimizations#222Snazzah wants to merge 11 commits intoprojectdysnomia:devfrom
Snazzah wants to merge 11 commits intoprojectdysnomia:devfrom
Conversation
Makes getChannel() fall back to linear search through all guilds in case guildIDHint is somehow incorrect (should happen only from user-land).
Snazzah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow for not using the
Client.channelGuildMap,Client.threadGuildMap, andClient.guildShardMapwhencaching.disableMapsis on.Some caveats:
getChannelwill do linear searching now, but this can be skipped with guild hinting.getChannelnow has aguildIDHintparameter for getting that specific guild rather than searching all of them. Which has some caveats:editChannelPosition's option param hasguildIDHint, it's channel's corresponding function will use it.joinVoiceChannelandleaveVoiceChannel, butleaveVoiceChannelhas it's hinting in a new parameter.ThreadMember's construction to find the guild will do linear searching, sad.getChanneleither now hint at the guild or just gets the guild directly.Not fully tested yet.