Use breaking version bump for fluent #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just yanked fluent-0.16.2. |
zbraniecki
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluent_bundleis a "public dependency" offluent. So a semver bump influent_bundleshould require a semver bump influent. #385It seems we have an issue with downstream projects using (indirectly)
fluent-bundle::*while at the same time the upstream project is usingfluent::fluent_bundle::*. This is kind of a weird arrangement, but given that we're exposing it it does seem like the resolver has trouble getting the right combination.Note
cargo semver-checksdid not catch this, but that may be a bug.If we yank 0.16.2 and replace it with 0.17.0 we might mitigate some of the pain downstream.
Thoughts?