Require whitespace before tags in description field #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v3.0.3 hamster harvests single word #hash tags from the description field. This PR tweaks the regex used to extract the tags, requiring whitespace before the # character. This will prevent harvesting a tag from a pattern like example.com/page#anchor, as mentioned here: projecthamster#753 (comment). This does not affect any of the test cases in test_stuff.py nor the example from the input.page documentation.
|
Automatically generated build artifacts for commit 90faaa7 (note: these links will expire after some time):
To test this PR, download and unzip the flatpak application above and then install with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v3.0.3 hamster harvests single word #hash tags from the description field. This PR tweaks the regex used to extract the tags, requiring whitespace before the # character. This will prevent harvesting a tag from a pattern like example.com/page#anchor, as mentioned here: #753 (comment).
This does not affect any of the test cases in test_stuff.py nor the examples from the input.page documentation.