Remove old window presentation workaround that causes timstamp overflows #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems with an uptime of > 49 days (32bit overflow of millisecond counters), I get warnings like this:
While they have no observable impact, somewhere down there things do go wrong.
Tracing through the code, this was a workaround for GTK 3.24.1 -- I'd claim that this was so long ago that nobody is using it any more, but the oldest version I could easily date through Debian was 3.24.24 (bullseye, 2021) and 3.24.32 (Ubuntu Jammy, 2022 LTS), and old changelog entries were purged from Debian packages in 2019 when it was at 3.24.10, so yeah it's really ancient.
(Before I looked up the version, I tried for workarounds
self.window.present_with_time(gdk.CURRENT_TIME)andself.window.present_with_time((glib.get_monotonic_time() // 1000) & 0xffffffff), which also worked, but really, I don't think we'll find anyone who can reproduce what this was a workaround for without serious archeology).