Deploy OpenWhisk API Gateway#10
Deploy OpenWhisk API Gateway#10kameshsampath wants to merge 6 commits intoprojectodd:simplify-deployment-openshiftfrom
Conversation
jcrossley3
left a comment
jcrossley3
left a comment
There was a problem hiding this comment.
Looks good, thanks! Would you mind renaming the files to *.yml please?
|
@jcrossley3 - renamed the files to |
bbrowning
left a comment
bbrowning
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've made some review requests - let me know if you need help figuring this out. Specifically, removing the need to hardcode hostnames and URL may take some thought to figure out.
openshift/apigateway.yml
Outdated
| kind: ConfigMap | ||
| metadata: | ||
| name: apigateway | ||
| namespace: openwhisk |
There was a problem hiding this comment.
Namespace should be left off here like the other OpenShift configs.
openshift/apigateway.yml
Outdated
| name: apigateway | ||
| namespace: openwhisk | ||
| data: | ||
| api_host: openwhisk-openwhisk.192.168.64.58.nip.io |
There was a problem hiding this comment.
api_host, apigw_url, and redis_host don't need to be hardcoded here. They need to be figured out dynamically in the case of api-host and apigw_url and perhaps set to just redis for redis_host.
There was a problem hiding this comment.
@bbrowning - actually I thought to deduce that, but don't know how we can do that - if we can do that then I don't need to have those api_host and apigw_url entries. Thoughts ?
openshift/apigateway.yml
Outdated
| labels: | ||
| app: redis | ||
| name: redis | ||
| namespace: openwhisk |
There was a problem hiding this comment.
Leave namespace off here as well.
openshift/apigateway.yml
Outdated
| labels: | ||
| app: redis | ||
| name: redis | ||
| namespace: openwhisk |
openshift/apigateway.yml
Outdated
| name: apigateway | ||
| labels: | ||
| name: apigateway | ||
| namespace: openwhisk |
openshift/apigateway.yml
Outdated
| kind: DeploymentConfig | ||
| metadata: | ||
| name: apigateway | ||
| namespace: openwhisk |
openshift/apigateway.yml
Outdated
| labels: | ||
| app: apigateway | ||
| name: apigateway | ||
| namespace: openwhisk |
| @@ -0,0 +1,39 @@ | |||
| apiVersion: batch/v1 | |||
There was a problem hiding this comment.
typo in this filename - should be apimanagement.yml
openshift/apimangement.yml
Outdated
| kind: Job | ||
| metadata: | ||
| name: install-apimanagement | ||
| namespace: openwhisk |
Signed-off-by: Kamesh Sampath <kamesh.sampath@hotmail.com>
Signed-off-by: Kamesh Sampath <kamesh.sampath@hotmail.com>
- Made the configmap to deduce or infer the values from env Signed-off-by: Kamesh Sampath <kamesh.sampath@hotmail.com>
…/incubator-openwhisk-deploy-kube into simplify-deployment-openshift
|
@bbrowning - i have fixed all the comments that you had. Please review and merge when you are at it . Currently there will be one parameter |
|
Opened new PR projectodd/openwhisk-openshift#4 and will track it there. |
3 participants
OpenShift resources to deploy OpenWhisk API Gateway to Openshift