Skip to content

Update Commodore to use get-helm-4 script to install the Helm binary #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simu merged 2 commits into from
Dec 17, 2025
Merged

Update Commodore to use get-helm-4 script to install the Helm binary #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869718a
Update Commodore to use `get-helm-4` script to install the Helm binary
simu Dec 17, 2025
d991259
Run `tools.setup_path()` in `init_env()` pytest session fixture
simu Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commodore/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
MANAGED_TOOLS_STATE = MANAGED_TOOLS_PATH / "state.json"

TOOL_INSTALL_SCRIPT_URL = {
"helm": "https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3",
"helm": "https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-4",
"kustomize": "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh",
}

Expand Down
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from click.testing import CliRunner, Result
from git import Repo

from commodore import cli
from commodore import cli, tools
from commodore.config import Config
from commodore.gitrepo import GitRepo

Expand All @@ -32,6 +32,7 @@ def __call__(self, args: list[str]) -> Result: ...
@pytest.fixture(autouse=True, scope="session")
def init_env():
multiprocessing.set_start_method("spawn")
tools.setup_path()


@pytest.fixture(autouse=True)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def test_install_helm(config: Config, capfd, tmp_path, github_token):

responses.add(
responses.GET,
"https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3",
"https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-4",
body=textwrap.dedent(
"""#!/bin/sh
echo 'Helm installer'
Expand Down