Skip to content

do not crash on incomplete media queries #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartveneman merged 1 commit into from
Feb 12, 2025
Merged

do not crash on incomplete media queries #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/atrules/atrules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function isMediaBrowserhack(prelude) {
return this.break
}
} else if (node.type === MediaFeature) {
if (value !== null && value.unit === '\\0') {
if (value && value.unit && value.unit === '\\0') {
returnValue = true
return this.break
}
Expand All @@ -81,15 +81,14 @@ export function isMediaBrowserhack(prelude) {
return this.break
}
else if (strEquals('min-resolution', name)
&& strEquals('.001', value.value)
&& value && strEquals('.001', value.value)
&& strEquals('dpcm', value.unit)
) {
returnValue = true
return this.break
}
else if (strEquals('-webkit-min-device-pixel-ratio', name)) {
let val = value.value
if ((strEquals('0', val) || strEquals('10000', val))) {
if (value && value.value && (strEquals('0', value.value) || strEquals('10000', value.value))) {
returnValue = true
return this.break
}
Expand Down
13 changes: 13 additions & 0 deletions src/atrules/atrules.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,19 @@ AtRules('finds @media browserhacks', () => {
assert.equal(actual, expected)
})

AtRules('does not crash on incomplete @media queries', () => {
let css = `
@media (min-width) {}
@media (-moz-images-in-menus) {}
@media (min--moz-device-pixel-ratio) {}
@media (-ms-high-contrast), (-ms-high-contrast) {}
@media (min-resolution) {}
@media (-webkit-min-device-pixel-ratio) {}
`

assert.not.throws(() => analyze(css))
})

AtRules('analyzes @keyframes', () => {
const fixture = `
@keyframes one {}
Expand Down
Loading