Skip to content

Conversation

@tim3nd
Copy link

@tim3nd tim3nd commented Dec 12, 2024

Add highlight support for blink.cmp.

blink.cmp has some builtin highlights mapping from cmp, so most highlights in this PR was token from it.

There are two points I think worth to specifically mention:

  • Border highlight group related
  • Doc separator highlight group
    • cmp seems handle separator as markdown separator ---, but blink.cmp has standalone highlight group BlinkCmpDocSeparator
    • personally I think separator highlight like border looks better, so here BlinkCmpDocSeparator is also linked to FloatBorder first ( like BlinkCmpDocBorder )

Love this awesome theme, thanks for your great work. Tell me anything if I can help :)


Screenshots (github-light and github-dark)

  • blink.cmp
    image
    image

  • cmp
    image
    image

@adinhodovic
Copy link

@tmillr could we merge this?

@luisdavim
Copy link

For now I've been using use_nvim_cmp_as_default but that will be removed in a future release of blink, so it would be great to get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants