Receive/refresh keys in parallel #17
Conversation
|
Could you rebase all of your PRs to pick up the CI fix? Thanks! |
desultory
force-pushed
the
parallel-fetch
branch
from
9256cf7 to
c300820
Compare
|
Also, needs a rebase. |
desultory
force-pushed
the
parallel-fetch
branch
2 times, most recently
from
3790168 to
fe47306
Compare
getuto
Outdated
| # TODO: keys.openpgp.org lacks a UID for our keys, need to verify email | ||
| for keyserver in "${mykeyservers[@]}" ; do | ||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true | ||
| einfo "Importing release engineering keys from: ${keyserver}" |
There was a problem hiding this comment.
This is adding unconditional status messages. Currently getuto only prints the major action being done (initializing, or updating, the keyring as a whole). I'm of two minds about this change, but either way, it deserves to be a distinct commit with distinct rationale, not "do it in parallel".
getuto
Outdated
| for keyserver in "${mykeyservers[@]}" ; do | ||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true | ||
| einfo "Importing release engineering keys from: ${keyserver}" | ||
| gpg ${QUIET_GPG} --batch --keyserver "${keyserver}" --recv-keys ${myrelkeys} || true & |
There was a problem hiding this comment.
Using & means that we inherently discard the exit status -- and wait without any options always returns true, not the exit status of the failed command. So it's really a replacement for || true...
There was a problem hiding this comment.
Using & means that we inherently discard the exit status -- and
waitwithout any options always returns true, not the exit status of the failed command. So it's really a replacement for|| true...
I think I fixed this, does it look right to you?
desultory
force-pushed
the
parallel-fetch
branch
from
fe47306 to
f1d2a95
Compare
Signed-off-by: Zen <z@pyl.onl>
Signed-off-by: Zen <z@pyl.onl>
desultory
force-pushed
the
parallel-fetch
branch
from
f1d2a95 to
a3a96e8
Compare
3 participants
This should cut the runtime in half