Add testcase to check for missing labels from the generated metrics #116
Merged
saswatamcode merged 5 commits intoprometheus-community:mainfrom Jan 16, 2025
Merged
Conversation
bwplotka
reviewed
Jan 14, 2025
metrics/serve_test.go
Outdated
| col.Stop(nil) | ||
| }) | ||
|
|
||
| time.Sleep((2 * time.Second)) |
Member
There was a problem hiding this comment.
Do you mind using some kind of wait e.g. assert.Eventually instead of sleep - much more efficient and reliable - or even better simply hijack (listen to) c.updateNotifyCh?
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback @bwplotka it makes sense , I have updated the test to use the c.upateNotifyCh for assertions
prateeknayak
force-pushed
the
fix-metrics-missing-labels
branch
from
893f13a to
e003269
Compare
Member
|
Do you mind rebasing? There are some unrelated changes now in this PR |
added 5 commits
January 16, 2025 19:07
Signed-off-by: Prateek <prateek@bluekanvas.com>
Signed-off-by: Prateek <prateek@bluekanvas.com>
Signed-off-by: Prateek <prateek@bluekanvas.com>
Signed-off-by: Prateek <prateek@bluekanvas.com>
Signed-off-by: Prateek <prateek@bluekanvas.com>
prateeknayak
force-pushed
the
fix-metrics-missing-labels
branch
from
7e2ed92 to
7ccc990
Compare
saswatamcode
approved these changes
Jan 16, 2025
saswatamcode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using avalanche to test out remote write capability in our distributed metrics architecture, we noticed that avalanche wasn't adding any labels let alone the
--const-labelsto the metrics. The solution in the PR should hopefully fix it.Following are the changes in the PR