Removed Continue on DialUp VPNs#176
Open
TomZille wants to merge 3 commits intoprometheus-community:mainfrom
Open
Removed Continue on DialUp VPNs#176TomZille wants to merge 3 commits intoprometheus-community:mainfrom
TomZille wants to merge 3 commits intoprometheus-community:mainfrom
Conversation
Dialup VPNs are not only used with Client RemoteAccess VPNs, so removed the continue/
Collaborator
|
Hi, thanks for the contribution! I am mostly concerned that removing this guard clause will cause metric duplication. Can you contribute a JSON output from the API with a configuration that has both the existing supported VPN (SSL I suppose?) and the one you want? That way we can ensure that we do not regress the existing support. |
Author
|
Hey, just send the JSON to you via Mail. |
|
Hello, when will this be fixed? |
Collaborator
|
I need somebody that has both VPN types to convince me that this doesn't break the existing users. I haven't been able to take time to do this myself. Also, the tests needs to pass - 2/3 are broken |
|
I opened the original issue (#170) and I have a 600E with regular IPSec, Dialup IPsec and SSLVPN all configured simultaneously. What can I do to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialup VPNs are not only used with Client RemoteAccess VPNs, so removed the
continue.It will fix #170