Rewrite of sdn_connector_status to stateset#368
Open
Philldomd wants to merge 4 commits intoprometheus-community:mainfrom
Open
Rewrite of sdn_connector_status to stateset#368Philldomd wants to merge 4 commits intoprometheus-community:mainfrom
Philldomd wants to merge 4 commits intoprometheus-community:mainfrom
Conversation
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Signed-off-by: Philip Örnfeldt <philip.ornfeldt@outlook.com>
Contributor
|
What problem does this PR actually solve? |
Contributor
Author
|
The problem we had was that this did not follow stateset rules. We have discussed the cardinality impact before but came to the conclussion that this is not an issue. I could keep the old implementation as well if needed, to not break compatibility. |
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR translates the connector state into prometheus stateset format.