Rename http client package#371
Open
Philldomd wants to merge 5 commits intoprometheus-community:mainfrom
Open
Conversation
The old package http produced a conflict with net/http from std library Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Philldomd
force-pushed
the
feature/rename-http-client-pkg
branch
from
20e9179 to
e258739
Compare
Contributor
Author
|
The lint and CI build will not handle this change correctly since the dependecy does not exist yet. |
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Contributor
|
@Philldomd we'd need to resolve the conflict on the bgp_neigbors (remember the rename of the function old -> 7_4?) before merging :) |
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Philldomd
force-pushed
the
feature/rename-http-client-pkg
branch
from
cba89cd to
10d7443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old package http produced a conflict with net/http from std library
Also removed archived from readme