Skip to content

[prometheus-memcached-exporter] Add ability to customize API version for service monitor #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

[prometheus-memcached-exporter] Add ability to customize API version for service monitor #5989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-memcached-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: prometheus-memcached-exporter
description: Prometheus exporter for Memcached metrics
type: application
version: 0.4.3
version: 0.5.0
# renovate: github=prometheus/memcached_exporter
appVersion: "v0.15.3"
home: https://github.com/prometheus/memcached_exporter
Expand Down
2 changes: 1 addition & 1 deletion charts/prometheus-memcached-exporter/templates/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if and ( .Capabilities.APIVersions.Has "monitoring.coreos.com/v1" ) ( .Values.serviceMonitor.enabled ) }}
apiVersion: monitoring.coreos.com/v1
apiVersion: {{ .Values.serviceMonitor.apiVersion }}
kind: ServiceMonitor
metadata:
{{- if .Values.serviceMonitor.labels }}
Expand Down
1 change: 1 addition & 0 deletions charts/prometheus-memcached-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ affinity: {}
serviceMonitor:
# When set true then use a ServiceMonitor to configure scraping
enabled: false
apiVersion: "monitoring.coreos.com/v1"
multipleTarget: false
targets: []
# for every targets, url and name must be set,
Expand Down