Skip to content

KubeClientCertificateExpiration alert false positives with cloud providers #6161 #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

KubeClientCertificateExpiration alert false positives with cloud providers #6161 #6162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
306e50f
Update kubernetes-system-apiserver.yaml
romankucherov-cmyk Sep 24, 2025
0c7b928
Merge pull request #1 from romankucherov-cmyk/romankucherov-cmyk-patch-1
romankucherov-cmyk Sep 25, 2025
cdf2fb9
Update sync_prometheus_rules.py
romankucherov-cmyk Sep 29, 2025
9f93735
Update values.yaml
romankucherov-cmyk Sep 29, 2025
2dbc62c
Update kubernetes-system-apiserver.yaml
romankucherov-cmyk Oct 1, 2025
3f609ac
Update sync_prometheus_rules.py
romankucherov-cmyk Oct 7, 2025
66ee274
Update values.yaml
romankucherov-cmyk Oct 7, 2025
356a360
Update Chart.yaml
romankucherov-cmyk Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kube-prometheus-stack/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ name: kube-prometheus-stack
sources:
- https://github.com/prometheus-community/helm-charts
- https://github.com/prometheus-operator/kube-prometheus
version: 77.11.0
version: 77.11.1
# renovate: github=prometheus-operator/prometheus-operator
appVersion: v0.85.0
kubeVersion: ">=1.25.0-0"
Expand Down
4 changes: 4 additions & 0 deletions charts/kube-prometheus-stack/hack/sync_prometheus_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ def new_representer(dumper, data):
'$.Values.defaultRules.node.fsSelector': {
'replacement': '{{ $.Values.defaultRules.node.fsSelector }}',
'init': ''},
# 601200 seconds = 6 days 22 hour. Used as the default threshold for kubeClientCertificateExpira
'601200': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here

'replacement': '{{ .Values.defaultRules.kubeClientCertificateExpiration | default "601200" }}',
'init': ''},
}

# standard header
Expand Down
2 changes: 1 addition & 1 deletion ...ts/kube-prometheus-stack/templates/prometheus/rules-1.14/kubernetes-system-apiserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,4 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
5 changes: 5 additions & 0 deletions charts/kube-prometheus-stack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,11 @@ defaultRules:
prometheusOperator: true
windows: true

# kubeClientCertificateExpiration specifies the lifetime of client certificates.
# The value is specified in seconds. 601200 seconds ≈ 6 days 22 hour.
# This value is chosen to align with the certificate rotation policy.
kubeClientCertificateExpiration: "601200"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more context/comments here.


# Defines the operator for namespace selection in rules
# Use "=~" to include namespaces matching the pattern (default)
# Use "!~" to exclude namespaces matching the pattern
Expand Down