Open
Conversation
twotired
force-pushed
the
fix-lint-errors
branch
3 times, most recently
from
389314f to
4868bc7
Compare
Contributor
Author
|
@bwplotka Could you help review? |
luisdavim
reviewed
Oct 7, 2022
luisdavim
left a comment
luisdavim
left a comment
There was a problem hiding this comment.
I don't see these getting flagged by any linter.
Member
|
Sorry for lag. We need rebase and improvement in our golangcilint (or even removal of it), so #156 can pass |
twotired
pushed a commit
to twotired/jiralert
that referenced
this pull request
May 8, 2023
Signed-off-by: Jason Wells <spinmaster@gmail.com>
twotired
pushed a commit
to twotired/jiralert
that referenced
this pull request
May 8, 2023
Signed-off-by: Jason Wells <spinmaster@gmail.com>
Signed-off-by: Jason Wells <spinmaster@gmail.com>
Contributor
Author
|
@bwplotka rebase complete, please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after these changes, "make lint" is successful
make lint ; echo $?